<html>
<head><meta charset="utf-8"><title>rename get_unchecked · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rename.20get_unchecked.html">rename get_unchecked</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="211297429"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rename%20get_unchecked/near/211297429" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rename.20get_unchecked.html#211297429">(Sep 25 2020 at 18:41)</a>:</h4>
<p>We've discussed <a href="#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bweekly.20meeting.5D.202020-09-10.20.2354818/near/209658621">here</a> to rename the unstable <code>get_unchecked</code> method to something more obscure to hit</p>



<a name="211297533"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rename%20get_unchecked/near/211297533" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rename.20get_unchecked.html#211297533">(Sep 25 2020 at 18:42)</a>:</h4>
<p>should we use a <code>_</code> prefix as an idea of internal attribute?</p>



<a name="211297557"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rename%20get_unchecked/near/211297557" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rename.20get_unchecked.html#211297557">(Sep 25 2020 at 18:42)</a>:</h4>
<p>and rename it to <code>_get_unchecked</code> or <code>__get_unchecked</code>?</p>



<a name="211297606"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rename%20get_unchecked/near/211297606" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rename.20get_unchecked.html#211297606">(Sep 25 2020 at 18:43)</a>:</h4>
<p>unsure how are we in general dealing with this kind of stuff and internal things that we want to "hide"</p>



<a name="211297765"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rename%20get_unchecked/near/211297765" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthew Jasper <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rename.20get_unchecked.html#211297765">(Sep 25 2020 at 18:44)</a>:</h4>
<p>I'm working on this now and went for <code>__iterator_get_unchecked</code> to make name collisions even less likely.</p>



<a name="211298362"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rename%20get_unchecked/near/211298362" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rename.20get_unchecked.html#211298362">(Sep 25 2020 at 18:48)</a>:</h4>
<p><span class="user-mention" data-user-id="116118">@Matthew Jasper</span> ok, I've it almost ready too but go ahead</p>



<a name="211298374"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rename%20get_unchecked/near/211298374" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rename.20get_unchecked.html#211298374">(Sep 25 2020 at 18:49)</a>:</h4>
<p>cc <span class="user-mention" data-user-id="116083">@pnkfelix</span> for him to be aware</p>



<a name="211301325"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rename%20get_unchecked/near/211301325" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rename.20get_unchecked.html#211301325">(Sep 25 2020 at 19:10)</a>:</h4>
<p><span class="user-mention" data-user-id="116118">@Matthew Jasper</span> saw <a href="https://github.com/rust-lang/rust/issues/77201">#77201</a>, <span aria-label="+1" class="emoji emoji-1f44d" role="img" title="+1">:+1:</span> in general I wouldn't rollup a PR that fixes a <code>P-critical</code> but given that this renames a method it may be unrisky to do so?</p>



<a name="211302270"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rename%20get_unchecked/near/211302270" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nagisa <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rename.20get_unchecked.html#211302270">(Sep 25 2020 at 19:14)</a>:</h4>
<p>I would go further and make this p=1</p>



<a name="211302787"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rename%20get_unchecked/near/211302787" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rename.20get_unchecked.html#211302787">(Sep 25 2020 at 19:16)</a>:</h4>
<p><span class="user-mention" data-user-id="123586">@nagisa</span> yeah, I've done that exactly</p>



<a name="211302873"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rename%20get_unchecked/near/211302873" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rename.20get_unchecked.html#211302873">(Sep 25 2020 at 19:16)</a>:</h4>
<p>but as I've said, in general I wouldn't rollup but maybe this is unrisky and we can rollup ?</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>